Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new TDIGEST commands and TDIGEST.CREATE compression #33

Merged
merged 2 commits into from
Oct 2, 2022
Merged

Implement new TDIGEST commands and TDIGEST.CREATE compression #33

merged 2 commits into from
Oct 2, 2022

Conversation

shacharPash
Copy link
Contributor

@shacharPash shacharPash commented Sep 29, 2022 •
edited by chayim
Loading

  • TDIGEST.CREATE now has [COMPRESSION compression] instead of [compression]
    • TDIGEST.RANK
    • TDIGEST.REVRANK
    • TDIGEST.BYRANK
    • TDIGEST.BYREVRANK
  • TDIGEST.QUANTILE: does not return quantiles (return just the estimates), don’t sort results
  • TDIGEST.MERGESTORE removed (merged into TDIGEST.MERGE which has an updated syntax)
    • Add two fields to TDIGEST.INFO
  • TDIGEST.CDF now support multiple inputs (TDIGEST.CDF key value [value...])
    • When the sketch is empty, TDIGEST.MIN and TDIGEST.MAX return NaN instead of DBL_MIN, DBL_MAX
  • TDIGEST.ADD weights must be integers now (and not floats)

@chayim chayim changed the title Update Tdigest Commands Implement new TDIGEST commands and TDIGEST.CREATE compression Oct 2, 2022
@chayim chayim added the feature label Oct 2, 2022
@shacharPash shacharPash marked this pull request as ready for review October 2, 2022 11:32
@shacharPash shacharPash merged commit 997a4fd into master Oct 2, 2022
@shacharPash shacharPash deleted the Update/Tdigest branch October 2, 2022 11:32
shacharPash added a commit that referenced this pull request Oct 2, 2022
@shacharPash
Implement new TDIGEST commands and TDIGEST.CREATE compression (#33)
2648aad 
* Update Tdigest Commands

* Fix Rank Commands Tests
shacharPash added a commit that referenced this pull request Oct 12, 2022
@shacharPash @chayim @slorello89
Add Redis Search Commands (#32)
62dbedd 
* Add Alias command

* Start FT.CERATE Command

* Start FTCreateParams class for FT.CERATE

* Add FT.CERATE command

* Fixing Schema and FieldName Classes

* Work on Schema class

* Add FT.SEARCH command

* Add FT.ALTER command

* Linking to the latest pre-release (#30)

* Linking to the latest pre-release

* spelling and a link

* Updading the version to v0.2.1 (#31)

* adding JSON commands (#29)

* adding JSON commands

* Change commands names

* some fixes

* adding missing commands, removing visibility modifiers in interface

* async breakout

Co-authored-by: shacharPash <s.pashchur@gmail.com>

* Implement new TDIGEST commands and TDIGEST.CREATE compression (#33)

* Update Tdigest Commands

* Fix Rank Commands Tests

* Test Commit

* Add Async Commands & tests

* Working on FT.INFO Command

* Finish FT.INFO Command

* Add AggregationRequest Class for FT.AGGREGATE Command

* Add FT.AGGREGATE Command + Tests

* Adding TODOs to commands that have not yet been implemented

* Add FT.CONFIG GET/SET Commands + Tests

* Add FT.CURSOR READ/DEL Commands

* Add FT.DICT(ADD/DEL/DUMP) Commands

* Add FT.DICT(ADD/DEL/DUMP) Async Commands + Tests

* Add FT.DROPINDEX Sync/Async Commands + Tests

* Fix Aggregate & Add more Commands

* Add FT.TAGVALS Sync/Async Command + Tests

* Add Sync/Async Tests for FT.ALIAS

* Fixing Tdigest.Add Command and Tests

Co-authored-by: Chayim <chayim@users.noreply.github.com>
Co-authored-by: Steve Lorello <42971704+slorello89@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shacharPash @chayim