Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable docker image being used to call compose when running tests #3046

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

tishun
Copy link
Collaborator

@tishun tishun commented Nov 5, 2024

Related to #2948

By default the testcontainers (specifically the Docker Compose Module) would use an additional container to deploy docker for the compose step (to avoid failures if the runner machine does not have docker compose).

However not only does this slow down the tests but - in some cases - it causes them to fail, as the docker container has only 30 seconds to start, and sometimes this is not enough to download it.

Forcing us to use local docker compose should help.

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Copy link
Contributor

@ggivo ggivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tishun tishun merged commit 68e0809 into redis:main Nov 5, 2024
5 checks passed
@tishun tishun deleted the topic/tishun/use-local-compose-for-tests branch November 5, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants