Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MEXISTS to CFCommands #2090

Closed
wants to merge 2 commits into from
Closed

Adding MEXISTS to CFCommands #2090

wants to merge 2 commits into from

Conversation

jspalink
Copy link

@jspalink jspalink commented Apr 6, 2022

Adding an implementation of MEXISTS to the list of CFCommands. This code is a barely edited copy of the corresponding Bloom Filter command.

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Adding a MEXISTS command for Cuckoo Filters.

Adding an implementation of MEXISTS to the list of CFCommands. This code is a barely edited copy of the corresponding Bloom Filter command.
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jspalink Thanks for the change! Do you think you could add a unit test as well?

@chayim
Copy link
Contributor

chayim commented Apr 24, 2022

@dvora-h Perhaps you can make sure we're testing properly here?

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2022

Codecov Report

Merging #2090 (c591e2b) into master (e5e265d) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master    #2090      +/-   ##
==========================================
- Coverage   92.44%   92.43%   -0.02%     
==========================================
  Files         104      104              
  Lines       24364    24369       +5     
==========================================
+ Hits        22524    22526       +2     
- Misses       1840     1843       +3     
Impacted Files Coverage Δ
redis/commands/bf/commands.py 96.61% <40.00%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e265d...c591e2b. Read the comment docs.

@dvora-h
Copy link
Collaborator

dvora-h commented Jun 23, 2022

Duplicate, the command was added in #2184

@dvora-h dvora-h closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants