Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CF.MEXISTS + Clean bf/commands.py #2184

Merged
merged 7 commits into from
May 23, 2022

Conversation

Avital-Fine
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Closes #2181

@Avital-Fine Avital-Fine requested review from dvora-h and chayim May 17, 2022 11:14
Copy link
Collaborator

@dvora-h dvora-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also - linters fails

redis/commands/bf/commands.py Outdated Show resolved Hide resolved
@dvora-h dvora-h added the feature New feature label May 18, 2022
@Avital-Fine Avital-Fine changed the title Support CF.MEXISTS Support CF.MEXISTS + Clean bf/commands.py May 18, 2022
@Avital-Fine Avital-Fine requested a review from dvora-h May 18, 2022 09:35
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2022

Codecov Report

Merging #2184 (cace8fd) into master (8a1feb3) will increase coverage by 0.00%.
The diff coverage is 92.59%.

@@           Coverage Diff           @@
##           master    #2184   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files         108      108           
  Lines       27398    27373   -25     
=======================================
- Hits        25204    25183   -21     
+ Misses       2194     2190    -4     
Impacted Files Coverage Δ
redis/commands/bf/commands.py 98.86% <92.30%> (+0.84%) ⬆️
tests/test_bloom.py 99.56% <100.00%> (+<0.01%) ⬆️
tests/test_cluster.py 97.02% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a1feb3...cace8fd. Read the comment docs.

@Avital-Fine Avital-Fine merged commit 9167a0e into redis:master May 23, 2022
@Avital-Fine Avital-Fine deleted the CF.MEXISTS branch May 23, 2022 16:26
@dvora-h dvora-h mentioned this pull request Jun 23, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing "mexists" command for Cuckoo filter
3 participants