Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PyJWT an optional dependency #3518

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

akx
Copy link
Contributor

@akx akx commented Feb 20, 2025

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

For users who do not need JWT auth, pulling in PyJWT and its transient dependencies is unnecessary.

This makes the JWT dependency optional. Follows up on #3462.

@petyaslavova
Copy link
Collaborator

Hi @akx thank you for your contribution! We’ll review your change soon.

@akx akx force-pushed the optional-jwt branch 2 times, most recently from 55caa7d to 8c62760 Compare February 25, 2025 14:05
Copy link
Collaborator

@petyaslavova petyaslavova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@petyaslavova petyaslavova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akx I forgot to request one more change... Currently in the actions.yml the optional dependency is added for installation and the tests are executing without issues, but the information about the change is not added to the CONTRIBUTING.md guide. Could you please update the instructions there as well?

@akx
Copy link
Contributor Author

akx commented Feb 26, 2025

@petyaslavova Done. That file doesn't note the hiredis or ocsp extras though either, but at least it now notes jwt.

@akx akx requested a review from petyaslavova February 26, 2025 15:02
@petyaslavova petyaslavova merged commit dbbe7a7 into redis:master Feb 27, 2025
37 checks passed
@akx akx deleted the optional-jwt branch February 27, 2025 08:26
@petyaslavova petyaslavova added the maintenance Maintenance (CI, Releases, etc) label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants