-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PyJWT an optional dependency #3518
Conversation
Hi @akx thank you for your contribution! We’ll review your change soon. |
55caa7d
to
8c62760
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akx I forgot to request one more change... Currently in the actions.yml the optional dependency is added for installation and the tests are executing without issues, but the information about the change is not added to the CONTRIBUTING.md guide. Could you please update the instructions there as well?
@petyaslavova Done. That file doesn't note the |
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
For users who do not need JWT auth, pulling in PyJWT and its transient dependencies is unnecessary.
This makes the JWT dependency optional. Follows up on #3462.