Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate redis-entraid dependency for tests #3521

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

akx
Copy link
Contributor

@akx akx commented Feb 21, 2025

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

This PR follows up on #3502 (comment).

It:

  • moves the duplicated redis-entraid specific testing code to a separate module
  • defers the imports for redis-entraid (so tests can be run even without redis-entraid installed; given redis-entraid is currently unlicensed, having it as a required dependency is problematic)
  • fixes the CI to uninstall the PyPI redis-py version that installing redis-entraid installs, and instead installs the working copy version as editable (so e.g. metadata.version() returns the correct version).

@akx

This comment was marked as outdated.

@petyaslavova
Copy link
Collaborator

Hi @akx thank you for your contribution! We’ll review your change soon.

@akx akx force-pushed the ci-entraid-fix branch 4 times, most recently from ec3f003 to f924ed6 Compare February 27, 2025 08:31
@akx
Copy link
Contributor Author

akx commented Feb 27, 2025

@petyaslavova @vladvildanov Rebased post #3518.

Copy link
Collaborator

@petyaslavova petyaslavova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@petyaslavova petyaslavova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great that the duplicated code has been extracted into a separate file—it will make maintenance and future extensions easier! 🙂 However, I have some concerns about some of the other changes in this PR. Please see my inline comments.

@akx akx force-pushed the ci-entraid-fix branch from 7c5fd0a to 73e98e1 Compare March 4, 2025 14:39
@akx akx force-pushed the ci-entraid-fix branch from 73e98e1 to dd2b7d3 Compare March 5, 2025 11:08
@akx akx requested review from petyaslavova and vladvildanov March 5, 2025 11:08
@petyaslavova petyaslavova added the maintenance Maintenance (CI, Releases, etc) label Mar 5, 2025
@petyaslavova petyaslavova merged commit 5891109 into redis:master Mar 5, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants