-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Isolate redis-entraid dependency for tests #3521
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Hi @akx thank you for your contribution! We’ll review your change soon. |
ec3f003
to
f924ed6
Compare
@petyaslavova @vladvildanov Rebased post #3518. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great that the duplicated code has been extracted into a separate file—it will make maintenance and future extensions easier! 🙂 However, I have some concerns about some of the other changes in this PR. Please see my inline comments.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
This PR follows up on #3502 (comment).
It:
metadata.version()
returns the correct version).