Skip to content

Fix dtype parsing from vectorizer kwargs #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

tylerhutcherson
Copy link
Collaborator

Fixing a bug in how we handled kwargs within the vectorizer classes after a recent change was introduced.

rbs333
rbs333 previously approved these changes Oct 21, 2024
Copy link
Collaborator

@rbs333 rbs333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me assuming we didn't have any other kwargs for process. Does seem like there's a need to run the linter tho

@tylerhutcherson
Copy link
Collaborator Author

Makes sense to me assuming we didn't have any other kwargs for process. Does seem like there's a need to run the linter tho

kwargs for the vectorizers are to be consumed by design by the client doing the vectorization. dtype however is reserved for the process_embedding helper, which does not need anything beyond the three explicit args. Thus, needs to get popped from the kwargs before processing.

@tylerhutcherson tylerhutcherson merged commit 6aa0111 into main Oct 21, 2024
20 checks passed
@tylerhutcherson tylerhutcherson deleted the bug/RAAE-365/fix-vectorizer-kwargs branch October 21, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants