Update the vectorized_cluster_partition_records_fetched field #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| namespace kafka { | ||
| class materialized_partition final : public kafka::partition_proxy::impl { | ||
| public: | ||
| explicit materialized_partition(storage::log log) | ||
| : _log(log) {} | ||
| explicit materialized_partition( |
There was a problem hiding this comment.
maybe we should have a separate metric for materialized partition ? I have this solved with virtualized interface for partition_probe this way we can provide different implementation for materialized partition
There was a problem hiding this comment.
Have you already written a solution for this? If so I don't want to step on your toes here
|
In progress by Michal: #1455 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our metrics dashboard graphs that use this field are left blank. It is because the value is never incremented.