Add fetch records metric #1455
Merged
Add fetch records metric #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaslankaprv
requested review from
BenPope and
graphcareful
and removed request for
a team
dotnwat
reviewed
May 24, 2021
Made `cluster::partition_probe` a class using PIMPL idiom to make it possible to provide different probe implementations for replicated and materialized partitions Signed-off-by: Michal Maslanka <michal@vectorized.io>
Record count calculation coming from fetch and produce Kafka APIs are done in Kafka layer. We have to provide a consistent way to access partition probe for both materialized and replicated partitions. Signed-off-by: Michal Maslanka <michal@vectorized.io>
Added missing update of partition probe with number of records fetched. Fixes: redpanda-data#1288 Signed-off-by: Michal Maslanka <michal@vectorized.io>
mmaslankaprv
force-pushed
the
add-fetch-records-metric
branch
from
577bb89 to
699790d
Compare
BenPope
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Correctly updating fetch records metric.
Fixes: #1288
Release notes