Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix cloud storage self-test start/end time output #21353

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

WillemKauf
Copy link
Contributor

@WillemKauf WillemKauf commented Jul 12, 2024

The start/end times for tests ran with the self-test tool were recently added to the output of rpk config self-test status.

These times were not being set in the cloud storage self-test, and thus the START and END times would both be epoch time, i.e

NAME          Cloud Storage Test
INFO          Put
TYPE          cloud
TEST ID       2cf3b181-3cb8-4502-a987-28dfd60f4f12
TIMEOUTS      0
START TIME    Thu Jan  1 00:00:00 UTC 1970
END TIME      Thu Jan  1 00:00:00 UTC 1970
AVG DURATION  7ms

This PR fixes the start and end time outputted for the result of the test, for either failed or successful tests.

NAME          Cloud Storage Test
INFO          Put
TYPE          cloud
TEST ID       0d40dc63-5a7f-43df-b175-de33411d1df9
TIMEOUTS      0
START TIME    Fri July  12 16:00:13 UTC 2024
END TIME      Fri July  12 16:00:13 UTC 2024
AVG DURATION  7ms

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

Improvements

  • Improve rpk cluster self-test status output for the cloud test.

This function will be used in the future outside of the `metrics` class,
so it is being split up initially here.
andrwng
andrwng previously approved these changes Jul 12, 2024
Copy link
Contributor

@andrwng andrwng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this hasn't made its way to a release yet, has it?

A wrapper function around various tests for timing purposes.
The `self-test status` will now have the properly formatted
start and end times, regardless of whether a test was successful
or not.
@WillemKauf
Copy link
Contributor Author

Force push to correct usage of ss::lowres_clock::now() to ss::lowres_system_clock::now().

@WillemKauf WillemKauf requested a review from andrwng July 12, 2024 16:38
@Deflaimun
Copy link
Contributor

Thanks for the fix @WillemKauf. Have you added start/end regardless of test status ?
Asking because this might be helpful for debugging purposes.

@WillemKauf
Copy link
Contributor Author

Thanks for the fix @WillemKauf. Have you added start/end regardless of test status ?

Asking because this might be helpful for debugging purposes.

Yes, start/end times will be outputted regardless of test failure/success.

@WillemKauf WillemKauf merged commit 46d6df2 into redpanda-data:dev Jul 12, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants