[v24.1.x] cloud_storage: add error_outcome::operation_not_supported
#22537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `abs_error_code::operation_not_supported_on_directory` for future handling of errors that arise when a `Delete Blob` request is made on a directory. (cherry picked from commit 1c235a4)
Adds a value to the `cloud_storage::error_outcome` enum for handling cases where the response to a request made had some flavor of `OperationNotSupported` code. This will be used immediately to handle a case for the `abs_client` where `Delete Blob` requests made on directories results in a `OperationNotSupportedOnDirectory` response. (cherry picked from commit 457faa0)
…abs_client::delete_object()` Previously, a `Delete Blob` request made on a directory in ABS would result in an `error_outcome` due to the `OperationNotSupportedOnDirectory` response. We now ignore this outcome instead of propagating an error, and issue a warning log to `abs_log`. (cherry picked from commit 744f322)
WillemKauf
approved these changes
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #22339