Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v24.1.x] cloud_storage: add error_outcome::operation_not_supported #22537

Merged
merged 3 commits into from
Jul 27, 2024
Merged

[v24.1.x] cloud_storage: add error_outcome::operation_not_supported #22537

merged 3 commits into from
Jul 27, 2024

Commits on Jul 26, 2024

  1. cloud_storage_clients: add abs_error_code::operation... 

    Add `abs_error_code::operation_not_supported_on_directory` for future
handling of errors that arise when a `Delete Blob` request is made
on a directory.

(cherry picked from commit 1c235a4)
    @WillemKauf @vbotbuildovich
    WillemKauf authored and vbotbuildovich committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    4046bb0 View commit details
    Browse the repository at this point in the history

  2. cloud_storage: add error_outcome::operation_not_supported 

    Adds a value to the `cloud_storage::error_outcome` enum for handling cases
where the response to a request made had some flavor of `OperationNotSupported`
code.

This will be used immediately to handle a case for the `abs_client` where
`Delete Blob` requests made on directories results in a
`OperationNotSupportedOnDirectory` response.

(cherry picked from commit 457faa0)
    @WillemKauf @vbotbuildovich
    WillemKauf authored and vbotbuildovich committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    88c8830 View commit details
    Browse the repository at this point in the history

  3. cloud_storage_clients: catch not_supported_on_directory errors in `… 

    …abs_client::delete_object()`

Previously, a `Delete Blob` request made on a directory in ABS would result
in an `error_outcome` due to the `OperationNotSupportedOnDirectory` response.
We now ignore this outcome instead of propagating an error, and issue a
warning log to `abs_log`.

(cherry picked from commit 744f322)
    @WillemKauf @vbotbuildovich
    WillemKauf authored and vbotbuildovich committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    a392093 View commit details
    Browse the repository at this point in the history