[v24.2.x] [CORE-6750] schema registry exclusiveMinumum/exclusiveMaximum double support #22658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with the passage to jsoncons for schema validation, this error message changed (cherry picked from commit 5183167)
…m: bool
exclusiveMinimum/Maximum in draft4 are booleans and defaults to false.
So this test case should pass:
160 + {
161 + .reader_schema
162 + = R"({"type": "number", "maximum": 10, "exclusiveMaximum": false})",
163 + .writer_schema = R"({"type": "number", "maximum": 10})",
164 + .reader_is_compatible_with_writer = true,
165 + },
this commit is a fix to make it work
(cherry picked from commit 4fcd586)
from draft6, exclusiveMinimum/Maximum are no longer booleans but doubles. add support for this if both schemas are >=draft6. mixed comparison (boolean/double or vice-versa) are technically possible, by using the minimum/maximum values, but are still rejected (cherry picked from commit b05bc0a)
andijcr
approved these changes
Jul 30, 2024
michael-redpanda
merged commit 450ec7e
into
redpanda-data:v24.2.x
15 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #22644