Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v24.2.x] [CORE-6750] schema registry exclusiveMinumum/exclusiveMaximum double support #22658

Merged
merged 3 commits into from
Jul 31, 2024
Merged

[v24.2.x] [CORE-6750] schema registry exclusiveMinumum/exclusiveMaximum double support #22658

merged 3 commits into from
Jul 31, 2024

Commits on Jul 30, 2024

  1. schema_registry/test_json_schema: fix expected exception message 

    with the passage to jsoncons for schema validation, this error message
changed

(cherry picked from commit 5183167)
    @andijcr @vbotbuildovich
    andijcr authored and vbotbuildovich committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    887823e View commit details
    Browse the repository at this point in the history

  2. schema_registry/json: fix is_numeric_superset exclusiveMinimum/Maximu… 

    …m: bool

exclusiveMinimum/Maximum in draft4 are booleans and defaults to false.
So this test case should pass:

160 +  {
161 +    .reader_schema
162 +    = R"({"type": "number", "maximum": 10, "exclusiveMaximum": false})",
163 +    .writer_schema = R"({"type": "number", "maximum": 10})",
164 +    .reader_is_compatible_with_writer = true,
165 +  },

this commit is a fix to make it work

(cherry picked from commit 4fcd586)
    @andijcr @vbotbuildovich
    andijcr authored and vbotbuildovich committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    6b83f9e View commit details
    Browse the repository at this point in the history

  3. schema_registry/json: add support for exclusiveMinimum/Maximum >=draft6 

    from draft6, exclusiveMinimum/Maximum are no longer booleans but
doubles.

add support for this if both schemas are >=draft6. mixed comparison
(boolean/double or vice-versa) are technically possible, by using the
minimum/maximum values, but are still rejected

(cherry picked from commit b05bc0a)
    @andijcr @vbotbuildovich
    andijcr authored and vbotbuildovich committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f3e797f View commit details
    Browse the repository at this point in the history