cluster: bump serde::version of start_test_request to 2
#22745
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This `serde::version<>` needed bumping to `serde::version<2>`, since `serde::version<0>` is the version of `start_test_request` with just `diskcheck_opts` and `netcheck_opts`, while `serde::version<1>` is the version with `unknown_checks` added, and `serde::version<2>` needs to reflect the most recently added `cloudcheck_opts`.
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/52508#019125f4-b96e-4986-8e7a-0d151cec3852 |
andrwng
reviewed
Aug 6, 2024
| @@ -341,7 +341,7 @@ struct empty_request | |||
| struct start_test_request | |||
| : serde::envelope< | |||
| start_test_request, | |||
| serde::version<1>, | |||
There was a problem hiding this comment.
ISTR we maybe don't need to bump if the difference in version doesn't span a release? Were cloudcheck_opts and unknown_checks added in the same version? Or was one backported but not the other?
There was a problem hiding this comment.
unknown_checks exists as of v24.1.x due to backports, cloudcheck_opts is only in v24.2.x.
|
Superseded by #22831. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
serde::version<>needed bumping toserde::version<2>, sinceserde::version<0>is the version ofstart_test_requestwith justdiskcheck_optsandnetcheck_opts(prev24.2.x), whileserde::version<1>is the version withunknown_checksadded, andserde::version<2>needs to reflect the most recently addedcloudcheck_opts(since versionv24.2.x).Backports Required
Release Notes