Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: bump serde::version of start_test_request to 2 #22745

Closed
wants to merge 1 commit into from
+1 −1
Closed

cluster: bump serde::version of start_test_request to 2 #22745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/v/cluster/self_test_rpc_types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ struct empty_request
struct start_test_request
: serde::envelope<
start_test_request,
serde::version<1>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISTR we maybe don't need to bump if the difference in version doesn't span a release? Were cloudcheck_opts and unknown_checks added in the same version? Or was one backported but not the other?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unknown_checks exists as of v24.1.x due to backports, cloudcheck_opts is only in v24.2.x.

serde::version<2>,
serde::compat_version<0>> {
using rpc_adl_exempt = std::true_type;

Expand Down
Loading