-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v24.2.x] CORE-6860 SR: Wire up support for ?verbose compatibility checks #23011
Merged
BenPope
merged 8 commits into
redpanda-data:v24.2.x
from
BenPope:vbotbuildovich/backport-22877-v24.2.x
Aug 23, 2024
Merged
[v24.2.x] CORE-6860 SR: Wire up support for ?verbose compatibility checks #23011
BenPope
merged 8 commits into
redpanda-data:v24.2.x
from
BenPope:vbotbuildovich/backport-22877-v24.2.x
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit 3771501)
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit b27954c) Conflicts: src/v/pandaproxy/BUILD (doesn't exist)
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit 25fcd5e)
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit d8bcac6)
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit 992a8e7)
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit 2825e14)
Signed-off-by: Oren Leiman <oren.leiman@redpanda.com> (cherry picked from commit 1e31632)
This matches the reference implementation and provides a more useful output because the users likely prefer comparing the new schema against the most recent incompatible schema. (cherry picked from commit dcf281c)
BenPope
requested review from
twmb,
r-vasquez,
gene-redpanda and
Deflaimun
as code owners
August 22, 2024 17:01
BenPope
requested review from
a team and
oleiman
and removed request for
twmb,
oleiman,
r-vasquez,
gene-redpanda,
Deflaimun and
a team
August 22, 2024 17:02
oleiman
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conflict on nonexistent bazel BUILD. LGTM
pgellert
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #22877
Fixes #22955