kafka: fix fetching from partitions with negative indexes #23301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the inputs may be directly from user requests, avoid asserting when encountering such malformed requests. Particularly requests like contains() and find() don't need to assert on non existent keys.
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/54407#0191e705-e156-4169-8482-f282de7c9f6b ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/54407#0191e707-9f4c-4b45-9f6b-8ea61545bb2e |
bashtanov
approved these changes
Sep 13, 2024
|
/backport v24.2.x |
This was referenced Sep 13, 2024
emaxerrno
reviewed
Sep 13, 2024
| key); | ||
| static bool valid_key(KeyT key) { | ||
| // map keys must be positive. | ||
| return key >= 0; |
There was a problem hiding this comment.
why use a generic type if it must be convertible to int?
There was a problem hiding this comment.
Template definition restricts it to integral types
template<std::integral KeyT, typename ValueT>
class contiguous_range_map {
There was a problem hiding this comment.
yeh i guess if we had a fixed integral type then we'd end up with various narrowing conversion warnings etc...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 24.2.x this was triggering an assert. Added a regression test.
Fixes #23296
Backports Required
Release Notes
Bug Fixes