[v24.1.x] compression: correct endianness in snappy_java_compressor (Manual backport)
#25137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 0352201)
The versions in the snappy header are written using big-endian format in the `snappy-java` client used by kafka. Mistakenly, `redpanda` would write them using little-endian format in our `snappy_java_compressor` implementation. Correct this by encoding and decoding the `version` and `compatible_version` headers using big-endian format in `snappy_java_compressor`. For references to `snappy-java`'s big-endian implementation, see: * https://github.com/xerial/snappy-java/blob/65e1ec3de1a0d447b137c6dd6393629aa3d75b8b/src/main/java/org/xerial/snappy/SnappyOutputStream.java#L343-L349 * https://github.com/xerial/snappy-java/blob/65e1ec3de1a0d447b137c6dd6393629aa3d75b8b/src/main/java/org/xerial/snappy/SnappyCodec.java#L78-L81 (cherry picked from commit 1c1b006)
Most `snappy` clients do not perform this version check, and furthermore, it is implemented incorrectly here. (cherry picked from commit 5723eb4)
(cherry picked from commit 72d02ee)
The two committed files in `snappy_payload` are a raw uncompressed data file, and a `snappy` compressed data file generated by `redpanda` using the incorrect little-endian encoding for the version fields in the `snappy` header. They are used in a unit test to ensure that with the big-endian fix for `snappy`, we are still able to decompress the buffer and get the same decompressed data as before the fix. (cherry picked from commit a84252d)
In order to allow `kafka-python` to use these compression types, we must be able to import the respective module. (cherry picked from commit 17a2e55)
To test compression compatibility with Java-based Kafka consumers/producers. These tests are parameterized for all compression types, but they most notably serve as reproducers for an outstanding header-field encoding bug in `snappy_java_compressor.cc`. (cherry picked from commit 379f380)
CI test resultstest results on build#62123
|
rockwotj
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick conflict in
setup.pyand bazelBUILDfiles.Also removed
test_upgrade_java_compressionfromjava_compression_test.pyin backports.Closes issue #25136.
Backports Required
Release Notes
Bug Fixes
snappy_java_compressorheaders to match that ofsnappy-java.