Testing Improvements

.buildkite/pipeline.yml

@@ -0,0 +1,105 @@
+agents:
+  queue: k8s-builders
+
+steps:
+  - label: lint
+    key: lint
+    command: make lint
+    plugins:
+      - docker#v5.11.0:
+          image: "golang:1.22"
+          environment:
+            - BUILDKITE=true
+  - label: unit
+    key: unit
+    command: make unit
+    plugins:
+      - docker#v5.11.0:
+          image: "golang:1.22"
+    depends_on:
+      - lint
+
+  - label: test_network
+    key: test_network
+    if: build.pull_request.labels includes 'ci-ready'
+    command: make test_network
+    plugins:
+      - seek-oss/aws-sm#v2.3.2:
+          json-to-env:
+            - secret-id: sdlc/prod/buildkite/integration_provider_secret_redpanda_client
+      - docker#v5.11.0:
+          image: "golang:1.22"
+          environment:
+            - INTEGRATION_PROVIDER_SECRET_REDPANDA_CLIENT_ID
+            - INTEGRATION_PROVIDER_SECRET_REDPANDA_CLIENT_SECRET
+    depends_on:
+      - lint
+      - unit
+  - label: test_cluster_aws
+    key: test_cluster_aws
+    if: build.pull_request.labels includes 'ci-ready'
+    command: make test_cluster_aws
+    plugins:
+      - seek-oss/aws-sm#v2.3.2:
+          json-to-env:
+            - secret-id: sdlc/prod/buildkite/integration_provider_secret_redpanda_client
+      - docker#v5.11.0:
+          image: "golang:1.22"
+          environment:
+            - INTEGRATION_PROVIDER_SECRET_REDPANDA_CLIENT_ID
+            - INTEGRATION_PROVIDER_SECRET_REDPANDA_CLIENT_SECRET
+    depends_on:
+      - lint
+      - unit
+      - test_network
+  - label: test_cluster_azure
+    key: test_cluster_azure
+    if: build.pull_request.labels includes 'ci-ready'
+    command: make test_cluster_azure
+    plugins:
+      - seek-oss/aws-sm#v2.3.2:
+          json-to-env:
+            - secret-id: sdlc/prod/buildkite/integration_provider_secret_redpanda_client
+      - docker#v5.11.0:
+          image: "golang:1.22"
+          environment:
+            - INTEGRATION_PROVIDER_SECRET_REDPANDA_CLIENT_ID
+            - INTEGRATION_PROVIDER_SECRET_REDPANDA_CLIENT_SECRET
+    depends_on:
+      - lint
+      - unit
+      - test_network
+  - label: test_cluster_gcp
+    key: test_cluster_gcp
+    if: build.pull_request.labels includes 'ci-ready'
+    command: make test_cluster_gcp
+    plugins:
+      - seek-oss/aws-sm#v2.3.2:
+          json-to-env:
+            - secret-id: sdlc/prod/buildkite/integration_provider_secret_redpanda_client
+      - docker#v5.11.0:
+          image: "golang:1.22"
+          environment:
+            - INTEGRATION_PROVIDER_SECRET_REDPANDA_CLIENT_ID
+            - INTEGRATION_PROVIDER_SECRET_REDPANDA_CLIENT_SECRET
+    depends_on:
+      - lint
+      - unit
+      - test_network
+  - label: test_serverless_cluster
+    key: test_serverless_cluster
+    if: build.pull_request.labels includes 'ci-ready'
+    command: make test_serverless_cluster
+    plugins:
+      - seek-oss/aws-sm#v2.3.2:
+          json-to-env:
+            - secret-id: sdlc/prod/buildkite/integration_provider_secret_redpanda_client
+      - docker#v5.11.0:
+          image: "golang:1.22"
+          environment:
+            - INTEGRATION_PROVIDER_SECRET_REDPANDA_CLIENT_ID
+            - INTEGRATION_PROVIDER_SECRET_REDPANDA_CLIENT_SECRET
+    depends_on:
+      - lint
+      - unit
+      - test_network

.github/workflows/docs.yml

@@ -11,10 +11,10 @@ jobs:
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           ref: ${{ github.head_ref }}
-          
+
       - name: Run make command
         run: make doc
 

.github/workflows/release.yml

@@ -1,15 +1,10 @@
 # Terraform Provider release workflow.
 name: Release
-
-# This GitHub action creates a release when a tag that matches the pattern
-# "v*" (e.g. v0.1.0) is created.
 on:
   push:
     tags:
       - 'v*'
 
-# Releases need permissions to read and write the repository contents.
-# GitHub considers creating releases and uploading assets as writing contents.
 permissions:
   contents: write
 
@@ -29,22 +24,22 @@ jobs:
           secret-ids: |
             ,sdlc/prod/github/tf_provider_rp
           parse-json-secrets: true
-      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+      - uses: actions/checkout@v4
         with:
           # Allow goreleaser to access older tag information.
           fetch-depth: 0
-      - uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
+      - uses: actions/setup-go@v5
         with:
           go-version-file: 'go.mod'
           cache: true
       - name: Import GPG key
-        uses: crazy-max/ghaction-import-gpg@82a020f1f7f605c65dd2449b392a52c3fcfef7ef # v6.0.0
+        uses: crazy-max/ghaction-import-gpg@v6
         id: import_gpg
         with:
           gpg_private_key: ${{ env.TF_PROVIDER_RP_GPG_PRIVATE_KEY }}
           passphrase: ${{ env.TF_PROVIDER_RP_PASSPHRASE }}
       - name: Run GoReleaser
-        uses: goreleaser/goreleaser-action@7ec5c2b0c6cdda6e8bbb49444bc797dd33d74dd8 # v5.0.0
+        uses: goreleaser/goreleaser-action@v6
         with:
           args: release --clean
         env:

.gitignore

@@ -26,3 +26,11 @@ terraform-provider-redpanda
 tools/tfplugindocs
 
 .idea/**
+
+**.terraform.d**
+**.terraform**
+**terraform.tfstate**
+**terraform.tfstate.backup**
+terraform-provider-hashicorp
+**/.tmp_*
+.cluster_info*

.golangci.yml

@@ -1,26 +1,12 @@
 run:
   allow-parallel-runners: true
-  skip-dirs:
-    - proto
 
 # golangci-lint by default ignores some staticcheck and vet raised issues that
 # are actually important to catch. The following ensures that we do not ignore
 # those tools ever.
 issues:
   exclude-use-default: false
   exclude-rules:
-    - linters:
-        - goconst
-      text: "string `UNSPECIFIED` has"
-      path: redpanda/utils/utils.go
-    - linters:
-        - goconst
-      text: "string `ANY` has"
-      path: redpanda/utils/utils.go
-    - linters:
-        - goconst
-      text: "string `UNKNOWN` has"
-      path: redpanda/utils/utils.go
     - path: _test\.go
       linters:
         - gocognit
@@ -93,20 +79,13 @@ linters-settings:
     require-explanation: true
     require-specific: true
 
-  # If gofumpt is run outside a module, it assumes Go 1.0 rather than the
-  # latest Go. We always want the latest formatting.
-  #
-  # https://github.com/mvdan/gofumpt/issues/137
-  gofumpt:
-    lang-version: "1.21"
   cyclop:
     max-complexity: 20
   gocyclo:
     min-complexity: 30
   gocognit:
     min-complexity: 30
   gci:
-    no-prefix-comments: true # no leading comment; we allow inline for nolint
     sections:
       - standard # stdlib
       - default # everything not std, not within cloudv2
@@ -127,18 +106,13 @@ linters-settings:
       - importShadow
       # disabled due to 1.18 failures
       - hugeParam
-      - rangeValCopy
-      - typeDefFirst
-      - paramTypeCombine
   # Revive is yet another metalinter with a lot of useful lints.
   # The below opts in to all the ones we would like to use.
   revive:
     ignore-generated-header: true
     enable-all-rules: true
     severity: warning
     confidence: 0.7
-    error-code: 1
-    warning-code: 1
     rules:
       - name: add-constant
         disabled: true