Testing Improvements #127
Merged
Testing Improvements #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gene-redpanda
force-pushed
the
add-testing-improvements
branch
from
7b297f5 to
33ce804
Compare
Goals were to consolidate examples into more general purpose cluster creation, expand the amount of stuff each one does so that users have to go to fewer places and have them in standardized locations. This is a NON FUNCTIONAL COMMIT, acceptance testing will fail.
The azure_private_link, aws_private_link and gcp_private_service_connect fields can only be used with their respective provider. This was causing fails on the cluster create call -- IOW about 20m into the process. Not ideal! The validator fails things at the terraform plan stage which saves the end user an immense amount of time.
Previously we were repeating the same test code in a LOT of places. This cuts all that away. Next up is standing up multiple clusters using the providers for long term testing purposes.
Dummy values cause failures in tests on GCP
andrewhsu
reviewed
Aug 6, 2024
Co-authored-by: Andrew Hsu <xuzuan@gmail.com>
andrewhsu
reviewed
Aug 6, 2024
Co-authored-by: Andrew Hsu <xuzuan@gmail.com>
Ideally this would also have an API call to request the current throughput tiers with the baked tiers as a fallback but I didn't see that yet.
…a-data/terraform-provider-redpanda into add-testing-improvements
Added a bunch of mocks and unit tests to validate the more complex utils functions. Also added mock gen and relevant makefile elements.
Cluster was hard to read with all the supporting functions making the file super long. This way it is clearer what elements are part of the terraform config and what elements are supporting
The new changes allow the user to build a provider binary and use it to run any of the cluster examples for testing purposes. It will generate a random name and then persist it (git knows to ignore the file) across make runs so you can teardown/run again without issues. Note that you must set REDPANDA_CLIENT_ID and REDPANDA_CLIENT_SECRET as usual, and must also set REDPANDA_CLOUD_ENVIRONMENT (probably to ign, but this allows you to target prd as well). The intent is to support development by making it easier to build and test against a specific cluster (no deletion) repeatedly without having to fiddle around with the acceptance tests. This will be most useful when developing against the dataplane endpoints but should still have value for cluster creation testing as it is easier to fiddle the HCL directly against a cluster and then explore what went wrong.
TF was persisting the extra quotes with \
Updated the makefile to support running tests in buildkite. Updated the buildkite pipeline to support running the make tests, making sure to put the slow and expensive cluster tests behind lint, unit and network tests.
Since we're already handling the linting in buildkite and it is an integral part of the testing process it makes no sense to also do it in actions as part of the release flow. I also bumped the plugin versions on the remaining actions pipelines
gene-redpanda
force-pushed
the
add-testing-improvements
branch
from
2198986 to
77ed6cf
Compare
gene-redpanda
force-pushed
the
add-testing-improvements
branch
from
9e0863b to
2860c71
Compare
Fixes an issue with a current install pack in integration that does not correctly work with GCP.
gofumpt doesn't support the property lang-version we no longer need the exclude word rules gci doesn't support no-prefix-comments also includes file fixes for linter + headers revive doesnt support error or warning
You still only need to change testtype. I've added the DATASOURCE_TEST_DIR to allow toggling between them without messing up the name persisting by cloud provider. standup and teardown are the verbs for local dev, no other thought needed there.
gene-redpanda
force-pushed
the
add-testing-improvements
branch
from
bed84e2 to
caa1509
Compare
Merged
r-vasquez
reviewed
Sep 9, 2024
Also rename standup to apply
Users should not provide a topic config element with an empty value.
gene-redpanda
force-pushed
the
add-testing-improvements
branch
from
27a0bbc to
89c6578
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes to improve both testing and the developer experience. It also contains fixes for various bugs discovered as part of implementing more comprehensive tests, doc changes and mocks.