Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: update to use oidc #131

Merged
merged 3 commits into from
Sep 26, 2024
Merged

gha: update to use oidc #131

merged 3 commits into from
Sep 26, 2024

Conversation

andrewhsu
Copy link
Member

@andrewhsu andrewhsu commented Aug 19, 2024

jira: PESDLC-1740

update gha workflows to use oidc to retrieve secrets

@andrewhsu andrewhsu force-pushed the PESDLC-1740-gh-oidc branch 4 times, most recently from 9edd0ab to 08ab2ba Compare August 19, 2024 16:48
@andrewhsu andrewhsu requested a review from ivotron August 19, 2024 16:53
@andrewhsu andrewhsu marked this pull request as ready for review August 19, 2024 16:53
Copy link
Contributor

@gene-redpanda gene-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts with an existing PR on this issue

@andrewhsu
Copy link
Member Author

andrewhsu commented Aug 19, 2024

converting this PR to draft until PR #127 resolves so i can rebase my changes on top of it

@andrewhsu andrewhsu marked this pull request as draft August 19, 2024 17:00
@gene-redpanda
Copy link
Contributor

@andrewhsu we're ready for recheck against main.

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2024

CLA assistant check
All committers have signed the CLA.

@andrewhsu andrewhsu marked this pull request as ready for review September 23, 2024 05:11
@andrewhsu
Copy link
Member Author

rebased PR on top of main. ready for review.

Copy link
Contributor

@gene-redpanda gene-redpanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gene-redpanda gene-redpanda merged commit 1d51c63 into main Sep 26, 2024
5 checks passed
@gene-redpanda gene-redpanda deleted the PESDLC-1740-gh-oidc branch September 26, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants