Fix missed case in "observe" type check #2919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redux briefly checks that observer received in observe function is a valid object and throw TypeError with useful user message if is not.
However, it missed null case, as
typeof null === 'object'(well-known js issue) and then failed with the obscure error messageCannot read property 'next' of null. I'm sure that there is no reason to not to show the correct error message in all relevant caseshttps://github.com/reactjs/redux/blob/master/src/createStore.js#L237
This PR fixes that inconsistency by throwing TypeError with the same useful message in case of null observer
Note that this PR is not a breaking change in any way