Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missed case in "observe" type check #2919

Merged
merged 3 commits into from
Apr 8, 2018
Merged

Fix missed case in "observe" type check #2919

merged 3 commits into from
Apr 8, 2018

Commits on Apr 7, 2018

  1. Make sure that assumed TypeError would be thrown

    @zerobias
    zerobias committed Apr 7, 2018
    Configuration menu
    Copy the full SHA
    172623e View commit details
    Browse the repository at this point in the history

  2. Check that ThrowError would be thrown in case of null observer object

    @zerobias
    zerobias committed Apr 7, 2018
    Configuration menu
    Copy the full SHA
    ab93291 View commit details
    Browse the repository at this point in the history

  3. Add null check for subscribe method

    @zerobias
    zerobias committed Apr 7, 2018
    Configuration menu
    Copy the full SHA
    dca1ce3 View commit details
    Browse the repository at this point in the history