Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include TEST_DATABASE_URL in docs and .env.example #1620

Closed
Darth-Knoppix opened this issue Jan 9, 2021 · 2 comments · Fixed by redwoodjs/create-redwood-app#123
Closed

Include TEST_DATABASE_URL in docs and .env.example #1620

Darth-Knoppix opened this issue Jan 9, 2021 · 2 comments · Fixed by redwoodjs/create-redwood-app#123
Labels
topic/crwa create-redwood-app topic/testing

Comments

@Darth-Knoppix
Copy link

When using Postgres and running tests with yarn rw test api, I receive the following error:

error: Error validating datasource `DS`: The URL for datasource `DS` must start with the protocol `postgresql://`.

Taking a look at the cli command source, it's expecting a test database url (TEST_DATABASE_URL) to be defined if the Prisma provider is Postgres.

If this is intended, it might be a useful to mention this behaviour in the docs and/or add it to .env.example to save some time.
@dthyresson dthyresson added topic/crwa create-redwood-app topic/testing labels Jan 9, 2021
jvanbaarsen added a commit to jvanbaarsen/create-redwood-app that referenced this issue Jan 10, 2021
@jvanbaarsen
Add TEST_DATABASE_URL to the default .env
61aba05 
Currently it is a bit implicit that you can use the `TEST_DATABASE_URL`
env variable. I was able to figure this out by looking through the
source code, and since someone posted this on the issue tracker it means
more people find it a bit implicit.

Fixes: redwoodjs/redwood#1620
@jvanbaarsen jvanbaarsen mentioned this issue Jan 10, 2021
Merged
@jvanbaarsen
Copy link
Contributor

Added a PR for this: redwoodjs/create-redwood-app#123

@thedavidprice thedavidprice mentioned this issue Jan 12, 2021
Closed
5 tasks
@thedavidprice
Copy link
Contributor

Will be included in v0.23.0 release

jtoar pushed a commit that referenced this issue Oct 26, 2023
@renovate
fix(deps): update dependency react-player to v2.13.0 (#9346)
4505b60 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [react-player](https://togithub.com/CookPete/react-player) | [`2.12.0`
->
`2.13.0`](https://renovatebot.com/diffs/npm/react-player/2.12.0/2.13.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-player/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-player/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-player/2.12.0/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-player/2.12.0/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>CookPete/react-player (react-player)</summary>

###
[`v2.13.0`](https://togithub.com/CookPete/react-player/blob/HEAD/CHANGELOG.md#v2130)

[Compare
Source](https://togithub.com/CookPete/react-player/compare/v2.12.0...v2.13.0)

- Fix
[#&#8203;1604](https://togithub.com/CookPete/react-player/issues/1604) -
FilePlayer does not work if I passed an array of urls
[`#1612`](https://togithub.com/cookpete/react-player/pull/1612)
- fix: `src` sttribute become "undefinded" if `url` is an array
[`#1648`](https://togithub.com/cookpete/react-player/pull/1648)
- Adding keepPlaying to other player types
[`#1639`](https://togithub.com/cookpete/react-player/pull/1639)
-   CI [`#1654`](https://togithub.com/cookpete/react-player/pull/1654)
- Swap out broken youtube URL
[`#1659`](https://togithub.com/cookpete/react-player/pull/1659)
- Add keepPlaying to seekTo
[`#1620`](https://togithub.com/cookpete/react-player/pull/1620)
- Added forceDisableHls option for FilePlayer
[`#1625`](https://togithub.com/cookpete/react-player/pull/1625)
- added onPlaybackQualityChange prop
[`#1636`](https://togithub.com/cookpete/react-player/pull/1636)
- Update the list of supported YouTube domains
[`#1599`](https://togithub.com/cookpete/react-player/pull/1599)
- Fix
[#&#8203;1604](https://togithub.com/CookPete/react-player/issues/1604) -
FilePlayer does not work if I passed an array of urls
([#&#8203;1612](https://togithub.com/CookPete/react-player/issues/1612))
[`#1604`](https://togithub.com/cookpete/react-player/issues/1604)
- Support Wisita URLs with query params
[`#1591`](https://togithub.com/cookpete/react-player/issues/1591)
- Support vimeo manage links
[`#1593`](https://togithub.com/cookpete/react-player/issues/1593)
- Update readme
[`90237f5`](https://togithub.com/cookpete/react-player/commit/90237f51d43fc63870b0e6d0c86f4497f97ca586)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jtoar pushed a commit that referenced this issue Nov 2, 2023
@renovate @jtoar
fix(deps): update dependency react-player to v2.13.0 (#9346)
ec38067 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [react-player](https://togithub.com/CookPete/react-player) | [`2.12.0`
->
`2.13.0`](https://renovatebot.com/diffs/npm/react-player/2.12.0/2.13.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-player/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-player/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-player/2.12.0/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-player/2.12.0/2.13.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>CookPete/react-player (react-player)</summary>

###
[`v2.13.0`](https://togithub.com/CookPete/react-player/blob/HEAD/CHANGELOG.md#v2130)

[Compare
Source](https://togithub.com/CookPete/react-player/compare/v2.12.0...v2.13.0)

- Fix
[#&#8203;1604](https://togithub.com/CookPete/react-player/issues/1604) -
FilePlayer does not work if I passed an array of urls
[`#1612`](https://togithub.com/cookpete/react-player/pull/1612)
- fix: `src` sttribute become "undefinded" if `url` is an array
[`#1648`](https://togithub.com/cookpete/react-player/pull/1648)
- Adding keepPlaying to other player types
[`#1639`](https://togithub.com/cookpete/react-player/pull/1639)
-   CI [`#1654`](https://togithub.com/cookpete/react-player/pull/1654)
- Swap out broken youtube URL
[`#1659`](https://togithub.com/cookpete/react-player/pull/1659)
- Add keepPlaying to seekTo
[`#1620`](https://togithub.com/cookpete/react-player/pull/1620)
- Added forceDisableHls option for FilePlayer
[`#1625`](https://togithub.com/cookpete/react-player/pull/1625)
- added onPlaybackQualityChange prop
[`#1636`](https://togithub.com/cookpete/react-player/pull/1636)
- Update the list of supported YouTube domains
[`#1599`](https://togithub.com/cookpete/react-player/pull/1599)
- Fix
[#&#8203;1604](https://togithub.com/CookPete/react-player/issues/1604) -
FilePlayer does not work if I passed an array of urls
([#&#8203;1612](https://togithub.com/CookPete/react-player/issues/1612))
[`#1604`](https://togithub.com/cookpete/react-player/issues/1604)
- Support Wisita URLs with query params
[`#1591`](https://togithub.com/cookpete/react-player/issues/1591)
- Support vimeo manage links
[`#1593`](https://togithub.com/cookpete/react-player/issues/1593)
- Update readme
[`90237f5`](https://togithub.com/cookpete/react-player/commit/90237f51d43fc63870b0e6d0c86f4497f97ca586)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic/crwa create-redwood-app topic/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add TEST_DATABASE_URL to the default .env jvanbaarsen/create-redwood-app
4 participants
@thedavidprice @dthyresson @jvanbaarsen @Darth-Knoppix