Upgrade Command should run from root regardless of current directory

[thedavidprice]

If a user runs yarn rw upgrade ... from a directory other than project root, there are cases where the root package.json is not handled correctly by yarn ('cause yarn is a mess when it comes to this command).

We need to ensure Execa has cwd set whenever it is called:
https://github.com/redwoodjs/redwood/blob/main/packages/cli/src/commands/upgrade.js

[jeliasson]

@thedavidprice 👋
To which path do we want to cwd to, and is there any specific case/command you think of?

// traverses from ./node_modules/@redwoodjs/cli/dist/commands
const example1 = path.resolve(__dirname, '../../../../../')

// traverses from ./api (for some reason?)
const example2 = path.resolve(process.cwd(), '..') 

Both examples resolves to the root of the project.

[thedavidprice]

Project root where ./package.json is located.

Check out the helpers here!
https://github.com/redwoodjs/redwood/blob/main/packages/internal/src/paths.ts

[Aditya-1804078]

I am new to open source community, can you please assign this issue to me?? Working on this issue would be a start for me.

[jeliasson]

@Aditya-1804078
I'm sure you'll have @thedavidprice blessing, so go for it. Let us know if you'd need any help to get started, and welcome to the open source community! 😊

[thedavidprice]

Indeed! Thanks for jumping in here @Aditya-1804078

Getting Started with Contributing Docs

• https://redwoodjs.com/docs/contributing
• CLI Package: https://github.com/redwoodjs/redwood/blob/main/packages/cli/README.md

Code Reference

• Command to update: https://github.com/redwoodjs/redwood/blob/main/packages/cli/src/commands/upgrade.js
• Take a look at how setting working directory is handled here:

  redwood/packages/cli/src/commands/setup/tailwind/tailwind.js

  Line 146 in 2f44c51

  await execa('yarn', ['tailwindcss', 'init'], { cwd: basePath })

[qooqu]

hi all - just submitted a pr

#2081

[thedavidprice]

and merged!