-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(setup-deploy): refactor setup deploy #4065
Merged
thedavidprice
merged 11 commits into
redwoodjs:main
from
dac09:refactor/setup-deploy-cli
Jan 13, 2022
Merged
chore(setup-deploy): refactor setup deploy #4065
thedavidprice
merged 11 commits into
redwoodjs:main
from
dac09:refactor/setup-deploy-cli
Jan 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dac09
added
release:chore
This PR is a chore (means nothing for users)
release:feature
This PR introduces a new feature
labels
Jan 7, 2022
cannikin
approved these changes
Jan 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@thedavidprice I saw you commented something about a regression, but I don't see the comment when I click through on the email notification from Github. What's up? |
@cannikin too. many. tabs. Nothing to see here... |
17 tasks
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Jan 17, 2022
…ize-jest-config * 'main' of github.com:redwoodjs/redwood: (32 commits) Update dependency eslint to v8.7.0 (redwoodjs#4168) remove projects beta automation (redwoodjs#4171) Update dependency core-js to v3.20.3 (redwoodjs#4162) Don't mask GraphQL errors when you're in the dev environment (redwoodjs#4166) Update storybook monorepo to v6.4.13 (redwoodjs#4160) Fix: Run web tests in parallel (redwoodjs#4024) Update Issue and PR templates with v1-rc status (redwoodjs#4155) Update dependency fast-glob to v3.2.11 (redwoodjs#4158) Update dependency @auth0/auth0-spa-js to v1.19.4 (redwoodjs#4153) Update dependency react-hook-form to v7.24.0 (redwoodjs#4149) Update dependency @clerk/clerk-sdk-node to v2.6.1 (redwoodjs#4151) Update prisma monorepo to v3.8.1 (redwoodjs#4152) Update e2e.yaml Update dependency firebase to v9.6.3 (redwoodjs#4148) chore(setup-deploy): refactor setup deploy (redwoodjs#4065) Update dependency mini-css-extract-plugin to v2.4.7 (redwoodjs#4142) test project install autoprefixer@^9.8.8 (redwoodjs#4143) Update dependency @graphql-codegen/typescript-react-apollo to v3.2.4 (redwoodjs#4137) Render all MetaTag tags within a `<Head>` element (redwoodjs#4128) fix: running tests with mysql datasource (redwoodjs#4084) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the setup deploy command, and update serverless deploy integration
Changes to the SLS integration
Merges in changes collected in the branch
serverless-deploy-3686
Why the refactor?
This decouples the logic between providers a lot, and makes the code a lot more maintainable (and grokable). I need this as a pre-requisite for making some changes to the serverless integration.
The current way deploy commands work are extremely restrictive, this refactor does the following:
Full Explanation