chore(deps): update dependency @testing-library/jest-dom to v6 #9673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/testing-library-jest-dom-6.x
branch
from
adc0d9a to
dc7c950
Compare
renovate
bot
force-pushed
the
renovate/testing-library-jest-dom-6.x
branch
from
dc7c950 to
5fe900b
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
jtoar
added a commit
that referenced
this pull request
Dec 15, 2023
This reverts #9673 and #9711. With v6 of `@testing-library/jest-dom`, `yarn rw type-check` fails in Redwood projects because it can't locate the types for `@testing-libary/jest-dom`. They absorbed the definitely types package (`@types/testing-library__jest-dom`) in this PR: testing-library/jest-dom#511. Here's an example of a failing run: https://github.com/redwoodjs/redwood/actions/runs/7213177056/job/19668365614?pr=9708. The logical thing to do is remove `@testing-libary/jest-dom` from the `types` array in `web/tsconfig.json`, but when we do that we get a different failure from TS saying that it doesn't understand the extended matchers provided by `testing-library/jest-dom` like `toBeInTheDocument`. @Tobbe filed an issue in their repo here testing-library/jest-dom#559. In the PR I linked to, the maintainer notes that... > But in my local testing with the changes in this PR, following the Readme was sufficient to get full auto-complete support even for JS-only users. As long as they have a jest-setup file that imports the bare export and add a dependency on @types/jest, recent versions of VS Code will figure it out. Users don't have jest setup files in their project (we just point to a jest preset) or `@types/jest` as an explicit dev dependency. I took a look at it but couldn't crack it today. Instead of holding up other PRs in CI, better to revert it for now and come back to later when we have more leads.
Tobbe
pushed a commit
that referenced
this pull request
Dec 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@testing-library/jest-dom](https://togithub.com/testing-library/jest-dom) | [`5.17.0` -> `6.1.5`](https://renovatebot.com/diffs/npm/@testing-library%2fjest-dom/5.17.0/6.1.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- <details> <summary>testing-library/jest-dom (@​testing-library/jest-dom)</summary> [`v6.1.5`](https://togithub.com/testing-library/jest-dom/releases/tag/v6.1.5) [Compare Source](https://togithub.com/testing-library/jest-dom/compare/v6.1.4...v6.1.5) - support uppercase custom props in toHaveStyle ([#​552](https://togithub.com/testing-library/jest-dom/issues/552)) ([b7b7c6a](https://togithub.com/testing-library/jest-dom/commit/b7b7c6a9652f259434d13a22e4319826a4bd4d8b)) [`v6.1.4`](https://togithub.com/testing-library/jest-dom/releases/tag/v6.1.4) [Compare Source](https://togithub.com/testing-library/jest-dom/compare/v6.1.3...v6.1.4) - upgrade `@adobe/css-tools` to `4.3.1` to address vulnerability ([#​532](https://togithub.com/testing-library/jest-dom/issues/532)) ([44f1eab](https://togithub.com/testing-library/jest-dom/commit/44f1eabc79b848f45daffac21c5f7383424e893c)) [`v6.1.3`](https://togithub.com/testing-library/jest-dom/releases/tag/v6.1.3) [Compare Source](https://togithub.com/testing-library/jest-dom/compare/v6.1.2...v6.1.3) - proper [@​jest/globals](https://togithub.com/jest/globals) import ([#​530](https://togithub.com/testing-library/jest-dom/issues/530)) ([5b492ac](https://togithub.com/testing-library/jest-dom/commit/5b492ace23d52b7cb7d3f91913ed0b5311905a26)) [`v6.1.2`](https://togithub.com/testing-library/jest-dom/releases/tag/v6.1.2) [Compare Source](https://togithub.com/testing-library/jest-dom/compare/v6.1.1...v6.1.2) - bump [@​adobe/css-tools](https://togithub.com/adobe/css-tools) for ESM support ([#​525](https://togithub.com/testing-library/jest-dom/issues/525)) ([b959a68](https://togithub.com/testing-library/jest-dom/commit/b959a681386164bf5d64f5b2b9c8bf891301bc12)) [`v6.1.1`](https://togithub.com/testing-library/jest-dom/releases/tag/v6.1.1) [Compare Source](https://togithub.com/testing-library/jest-dom/compare/v6.1.0...v6.1.1) - **package.json:** update main and module file paths ([#​523](https://togithub.com/testing-library/jest-dom/issues/523)) ([853a3e5](https://togithub.com/testing-library/jest-dom/commit/853a3e51ba6757a34780e32953525b6142eadcf9)) [`v6.1.0`](https://togithub.com/testing-library/jest-dom/releases/tag/v6.1.0) [Compare Source](https://togithub.com/testing-library/jest-dom/compare/v6.0.1...v6.1.0) - Publish ESM and CJS ([https://github.com/testing-library/jest-dom/pull/519](https://togithub.com/testing-library/jest-dom/pull/519)) [`v6.0.1`](https://togithub.com/testing-library/jest-dom/releases/tag/v6.0.1) [Compare Source](https://togithub.com/testing-library/jest-dom/compare/v6.0.0...v6.0.1) - matchers type is making the global expect unsafe ([#​513](https://togithub.com/testing-library/jest-dom/issues/513)) ([bdb34f1](https://togithub.com/testing-library/jest-dom/commit/bdb34f12959578c77b18b0c0910d512768b20ab0)) [`v6.0.0`](https://togithub.com/testing-library/jest-dom/releases/tag/v6.0.0) [Compare Source](https://togithub.com/testing-library/jest-dom/compare/v5.17.0...v6.0.0) - local types, supporting jest, [@​jest/globals](https://togithub.com/jest/globals), vitest ([#​511](https://togithub.com/testing-library/jest-dom/issues/511)) ([4b764b9](https://togithub.com/testing-library/jest-dom/commit/4b764b9f6a7b564d7f8ec0e9b0c6ba9cc875f2b8)) - Removes the extend-expect script. Users should use the default import path or one of the new test platform-specific paths to automatically extend the appropriate "expect" instance. extend-expect was not documented in the Readme, so this change should have minimal impact. Users can now use the following import paths to automatically extend "expect" for their chosen test platform: - [@​testing-library/jest-dom](https://togithub.com/testing-library/jest-dom) - jest ([@​types/jest](https://togithub.com/types/jest)) - @​testing-library/jest-dom/jest-globals - [@​jest/globals](https://togithub.com/jest/globals) - @​testing-library/jest-dom/vitest - vitest For example: import '@​testing-library/jest-dom/jest-globals' Importing from one of the above paths will augment the appropriate matcher interface for the given test platform, assuming the import is done in a .ts file that is included in the user's tsconfig.json. It's also (still) possible to import the matchers directly without side effects: import \* as matchers from '@​testing-library/jest-dom/matchers' - Update kcd-scripts - Drop node < 14 </details> --- 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
5.17.0->6.1.5Release Notes
testing-library/jest-dom (@testing-library/jest-dom)
v6.1.5Compare Source
Bug Fixes
v6.1.4Compare Source
Bug Fixes
@adobe/css-toolsto4.3.1to address vulnerability (#532) (44f1eab)v6.1.3Compare Source
Bug Fixes
v6.1.2Compare Source
Bug Fixes
v6.1.1Compare Source
Bug Fixes
v6.1.0Compare Source
Features
v6.0.1Compare Source
Bug Fixes
v6.0.0Compare Source
Features
BREAKING CHANGES
the default import path or one of the new test platform-specific
paths to automatically extend the appropriate "expect" instance.
extend-expect was not documented in the Readme, so this change should
have minimal impact.
Users can now use the following import paths to automatically extend
"expect" for their chosen test platform:
For example:
import '@testing-library/jest-dom/jest-globals'
Importing from one of the above paths will augment the appropriate
matcher interface for the given test platform, assuming the import
is done in a .ts file that is included in the user's tsconfig.json.
It's also (still) possible to import the matchers directly without
side effects:
import * as matchers from '@testing-library/jest-dom/matchers'
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.