Revert "Revert @testing-library/jest-dom v6 upgrade (#9713)"
#9719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
approved these changes
Dec 15, 2023
jtoar
reviewed
Dec 15, 2023
| @@ -25,8 +25,8 @@ | |||
| "types/*": ["./types/*", "../types/*"], | |||
| "@redwoodjs/testing": ["../node_modules/@redwoodjs/testing/web"] | |||
| }, | |||
| "typeRoots": ["../node_modules/@types", "./node_modules/@types"], | |||
| "types": ["jest", "@testing-library/jest-dom"], | |||
| "typeRoots": ["../node_modules/@types", "./node_modules/@types", "../node_modules/@testing-library"], | |||
There was a problem hiding this comment.
@Tobbe do we need jest and jest-dom?
There was a problem hiding this comment.
I'm not sure. The test project seems to work fine without jest. But I haven't looked into it more than that. So I'll add it back just to be sure.
Tobbe
force-pushed
the
tobbe-jest-dom-revert-revert
branch
from
f6b11dd to
664b739
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally figured out how to get the types working for
@testing-library/jest-dom!So can revert #9713, which reverted #9673 and #9711.
More details can also be found in an issue I created over at the jest-dom repo testing-library/jest-dom#559