This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add totalCount field to DatasetSchema type of GraphQL schema #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #154 +/- ##
==========================================
- Coverage 34.84% 34.81% -0.04%
==========================================
Files 351 351
Lines 31868 31901 +33
==========================================
Hits 11105 11105
- Misses 19751 19784 +33
Partials 1012 1012
|
I ran Is this way correct? |
rot1024
changed the title
fix: fix to count dataset rows, closes reearth/reearth#267
fix: fix to count dataset rows
May 31, 2022
keiya01
force-pushed
the
feature/fix-dataset-count
branch
from
June 2, 2022 12:04
37eb6bb
to
7fcc08f
Compare
keiya01
force-pushed
the
feature/fix-dataset-count
branch
from
June 2, 2022 12:30
d2d8008
to
d3ea8f5
Compare
rot1024
suggested changes
Jun 3, 2022
rot1024
changed the title
fix: count of dataset rows
feat: add totalCount field to DatasetSchema type in GraphQL
Jun 3, 2022
rot1024
changed the title
feat: add totalCount field to DatasetSchema type in GraphQL
feat: add totalCount field to DatasetSchema type of GraphQL schema
Jun 3, 2022
Co-authored-by: rot1024 <aayhrot@gmail.com>
Co-authored-by: rot1024 <aayhrot@gmail.com>
rot1024
approved these changes
Jun 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I fixed reearth/reearth-visualizer#267.
What I've done
CountBySchema
method to count dataset by schema id.What I haven't done
How I tested
Which point I want you to review particularly
Memo