Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

fix: dataset counts are displayed incorrectly in dataset pane #235

Merged
merged 3 commits into from
Jun 6, 2022

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented May 29, 2022

Overview

closes reearth/reearth-visualizer#267

This PR is related to reearth/reearth-backend#154.

What I've done

What I haven't done

How I tested

  1. run reearth-backend and reearth-web
  2. add dataset
  3. check dataset count

Screenshot

Screen Shot 2022-05-29 at 16 01 16

Which point I want you to review particularly

Memo

@keiya01 keiya01 self-assigned this May 29, 2022
@keiya01 keiya01 requested a review from KaWaite as a code owner May 29, 2022 07:01
@netlify
Copy link

netlify bot commented May 29, 2022

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 6c5dde7
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/629df4a73806fe00088b33c5
😎 Deploy Preview https://deploy-preview-235--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #235 (6c5dde7) into main (fc97324) will decrease coverage by 0.13%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
- Coverage   51.62%   51.48%   -0.14%     
==========================================
  Files          58       58              
  Lines        1170     1175       +5     
  Branches      184      184              
==========================================
+ Hits          604      605       +1     
- Misses        502      506       +4     
  Partials       64       64              
Impacted Files Coverage Δ
src/gql/graphql-client-api.tsx 35.62% <20.00%> (-0.21%) ⬇️

@keiya01 keiya01 force-pushed the feature/fix-dataset-count branch from d4bb3f1 to c5e7835 Compare June 2, 2022 12:23
@rot1024 rot1024 changed the title fix: fix to use DatasetSchema's totalCount, closes reearth/reearth#267 fix: fix to use DatasetSchema's totalCount Jun 3, 2022
@rot1024 rot1024 changed the title fix: fix to use DatasetSchema's totalCount fix: dataset counts are displayed incorrectly Jun 3, 2022
@rot1024 rot1024 changed the title fix: dataset counts are displayed incorrectly fix: dataset counts are displayed incorrectly in dataset pane Jun 3, 2022
Copy link
Member

@rot1024 rot1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me, but wait merging until reearth/reearth-backend#154 has been merged

@keiya01 keiya01 enabled auto-merge (squash) June 3, 2022 13:13
@rot1024 rot1024 disabled auto-merge June 6, 2022 14:03
@rot1024 rot1024 merged commit 45a0c85 into main Jun 6, 2022
@rot1024 rot1024 deleted the feature/fix-dataset-count branch June 6, 2022 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset total rows indicator in DatasetPane isn't showing correct value
2 participants