Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): update projects cache after delete #1167

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

airslice
Copy link
Contributor

@airslice airslice commented Oct 3, 2024

Overview

Instead of clear cache i added an update on cache to remove the deleted project.

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Summary by CodeRabbit

  • New Features

    • Enhanced project deletion functionality to automatically update the project list in the UI after a project is deleted.
  • Bug Fixes

    • Improved state management for project deletions to ensure accurate representation in the user interface.

@airslice airslice requested a review from mkumbobeaty as a code owner October 3, 2024 02:07
Copy link

coderabbitai bot commented Oct 3, 2024

Walkthrough

The changes in the projectApi.ts file focus on enhancing the deleteProjectMutation functionality. An update function has been added to modify the Apollo cache by removing the deleted project from the list of projects. This ensures that the UI accurately reflects the current state after a project deletion. Additionally, the import statements have been updated to include necessary components from the @apollo/client package, while the overall structure of the API service remains unchanged.

Changes

File Change Summary
web/src/services/api/projectApi.ts Added an update function to deleteProjectMutation for cache modification; updated import statements to include Reference and StoreObject.

Suggested labels

web

Suggested reviewers

  • mkumbobeaty

Poem

In the garden where projects bloom,
A rabbit hops, dispelling gloom.
With a flick of the tail, the old ones go,
The cache is fresh, with room to grow!
Hooray for changes, let’s all cheer,
For every project that brings us near! 🐇✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 8c8c8cf and 5cb090d.

📒 Files selected for processing (1)
  • web/src/services/api/projectApi.ts (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • web/src/services/api/projectApi.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 5cb090d
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/66fdfd90f151a900088c821b
😎 Deploy Preview https://deploy-preview-1167--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Oct 3, 2024
@github-actions github-actions bot requested a review from pyshx October 3, 2024 02:07
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e647233 and 8c8c8cf.

📒 Files selected for processing (1)
  • web/src/services/api/projectApi.ts (2 hunks)
🔇 Additional comments (1)
web/src/services/api/projectApi.ts (1)

1-3: Imports added are appropriate

The imports of Reference and StoreObject from @apollo/client are necessary for the cache modification logic and are correctly added.

@airslice airslice merged commit 6f6112a into main Oct 3, 2024
15 checks passed
@airslice airslice deleted the fix/update-projects-cache-after-delete branch October 3, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant