fix(web): style code condition operator match

[airslice]

Overview

Need to match >= <= ahead of > <

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Summary by CodeRabbit

• Bug Fixes

  • Adjusted the operator definitions in the ConditionsTab for better clarity and functionality.

• New Features

  • Enhanced the user experience for managing conditions without altering existing functionalities.

[coderabbitai]

Walkthrough

The changes in this pull request focus on the ConditionsTab component within ConditionsTab.tsx. The primary modification involves the styleConditionOperators array, where the operators "<" and ">" were removed and subsequently re-added, suggesting a redefinition without altering their overall presence. The functionality for managing conditions remains unchanged, including the handling of creating, updating, deleting, and dragging conditions.

Changes

File Path	Change Summary
web/src/beta/features/Editor/Map/LayerStylePanel/Editor/StyleInterface/StyleNode/ConditionsTab.tsx	Updated styleConditionOperators array by removing and re-adding the operators "<" and ">"; OPERATION_OPTIONS remains unchanged.

Possibly related PRs

• refactor(web): layer style editor node support typography #1168: This PR modifies the ConditionsTab component in ConditionsTab.tsx, which is directly related to the changes made in the main PR that also focuses on the ConditionsTab component.

Suggested labels

web

Suggested reviewers

• mkumbobeaty
• m-abe-dev

Poem

In the land of code where rabbits play,
Operators dance in a curious way.
With < and > now in a new light,
Conditions hop, oh what a sight!
The logic stays, but the style's refined,
A happy code, perfectly aligned! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for reearth-web ready!

Name	Link
🔨 Latest commit	a7d7d45
🔍 Latest deploy log	https://app.netlify.com/sites/reearth-web/deploys/6718c1955b87b100085a5d27
😎 Deploy Preview	https://deploy-preview-1191--reearth-web.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

web/src/beta/features/Editor/Map/LayerStylePanel/Editor/StyleInterface/StyleNode/ConditionsTab.tsx (1)

Line range hint 39-47: Align operator ordering in OPERATION_OPTIONS with styleConditionOperators.

While the ordering has been fixed in styleConditionOperators, the OPERATION_OPTIONS array still shows operators in a different order. This inconsistency could lead to confusion.

Apply this diff to maintain consistent ordering:

 const OPERATION_OPTIONS: {
   value: StyleConditionOperator;
   label: string;
 }[] = [
   { value: "===", label: "===" },
   { value: "!==", label: "!==" },
-  { value: ">", label: ">" },
-  { value: ">=", label: ">=" },
-  { value: "<", label: "<" },
   { value: "<=", label: "<=" },
+  { value: ">=", label: ">=" },
+  { value: "<", label: "<" },
+  { value: ">", label: ">" },
   { value: "startsWith", label: "Starts with" }
 ];

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 73dc7b7 and 263cdf7.

📒 Files selected for processing (1)

• web/src/beta/features/Editor/Map/LayerStylePanel/Editor/StyleInterface/StyleNode/ConditionsTab.tsx (1 hunks)

🧰 Additional context used

🔇 Additional comments (1)

web/src/beta/features/Editor/Map/LayerStylePanel/Editor/StyleInterface/StyleNode/ConditionsTab.tsx (1)

33-34: LGTM! Operator ordering fixed in styleConditionOperators.

The changes correctly implement the PR objective by ensuring <= and >= are prioritized before < and > in the styleConditionOperators array.