Fixed sitemap generation for multiple frontend locales #3218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| filter.around_generate({}) do | ||
| raw_url | ||
| end | ||
| end |
There was a problem hiding this comment.
It doesn't seem like raw_url is being returned anymore if this condition fails, as it's not being returned in the else case.
There was a problem hiding this comment.
You are right! Need to add else case to return raw_url without changes, or do some refactoring to get more effective correct code.
|
Thanks for taking a look at this! |
| @@ -17,6 +17,8 @@ xml.urlset "xmlns" => "http://www.sitemaps.org/schemas/sitemap/0.9" do | |||
| filter.around_generate({}) do | |||
| raw_url | |||
| end | |||
| else | |||
| raw_url | |||
There was a problem hiding this comment.
So, here is the fix, may be there are any better way to do it?
|
Good enough for me - @bricesanchez ? |
|
@sintro Could you squash and rebase your branch ? |
|
Done as a merge step |
bricesanchez
pushed a commit
that referenced
this pull request
Jul 16, 2016
* Fixed sitemap generation for multiple frontend locales * Added else case to return correct url when there are 1 frontend locale
bricesanchez
pushed a commit
that referenced
this pull request
Jul 16, 2016
* Fixed sitemap generation for multiple frontend locales * Added else case to return correct url when there are 1 frontend locale
bricesanchez
pushed a commit
that referenced
this pull request
Nov 29, 2016
and refactor the builder to be more readable
parndt
pushed a commit
that referenced
this pull request
Dec 11, 2016
and refactor the builder to be more readable
bricesanchez
pushed a commit
that referenced
this pull request
Aug 14, 2017
and refactor the builder to be more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to sitemap/index.xml.builder for correct generation when multiple frontend locales are activated.
More info in this #3215 issue.