You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
*args in App class are not used anywhere, except passing it to base __init__ (which in it's turns does not accept positional arguments)
Describe the bug
Here in the App class, the __init__() method accepts an arbitrary positional argument and then passes it to the base method. However, __init__() of Pydantic's BaseModel doesn't really accept any positional args (actually never has), only **kwargs. And I haven't seen any example where reflex App would be called with pos. args, so maybe it shouldn't be there.
Doesn't it make sense to remove passing positional args to the App class? It doesn't use them anywhere except pass it up to super()'s __init__ (i. e. BaseModel).
In short words
*args
inApp
class are not used anywhere, except passing it to base__init__
(which in it's turns does not accept positional arguments)Describe the bug
Here in the
App
class, the__init__()
method accepts an arbitrary positional argument and then passes it to the base method. However,__init__()
of Pydantic'sBaseModel
doesn't really accept any positional args (actually never has), only**kwargs
. And I haven't seen any example where reflexApp
would be called with pos. args, so maybe it shouldn't be there.Doesn't it make sense to remove passing positional args to the
App
class? It doesn't use them anywhere except pass it up tosuper()
's__init__
(i. e.BaseModel
).To Reproduce
Expected behavior
An exception that it couldn't take pos. arguments is raised from the
App
class, notBaseModel
.Specifics (please complete the following information):
The text was updated successfully, but these errors were encountered: