Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: args issue in __init__ of App class (#3140) #3141

Merged

Conversation

nautics889
Copy link
Contributor

@nautics889 nautics889 commented Apr 22, 2024

Remove passing *args to base __init__() in App.
Remove *args from signature.

Details in related issue.


  • (fix): remove '*args' from 'init()' method of 'App', update docstrings and .pyi accordingly

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

* (fix): remove '*args' from '__init__()' method of 'App', update
  docstrings and .pyi accordingly
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. This makes sense to me.

@nautics889
Copy link
Contributor Author

@masenf

And thanks to you for making such a great framework!

@picklelo picklelo merged commit 415ce55 into reflex-dev:main Apr 22, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants