Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a placeholder timeout to GitHub Actions unit tests #1897

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

jackwcodes
Copy link
Contributor

@jackwcodes jackwcodes commented Oct 1, 2023

All Submissions:

  • [ x ] Have you followed the guidelines stated in CONTRIBUTING.md file?
  • [ x ] Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

  • [ x ] Bug fix (non-breaking change which fixes an issue)

Change Description

This PR is in response to #1893 . I have added a placeholder timeout of 30 minutes for the unit-tests job in unit_tests.yml.

This placeholder may need to be revised to a lower timeout value (i.e. 10 or 15 mins). I looked through the last few weeks of unit tests, with successful tests finishing around 5 minutes or less, but unsuccessful tests exceeding past 10 min.

There are however outliers where the unit test ran for over an hour and was still successful.

Edit: Placeholder timeout values were added to all workflows as requested. See comment.

closes #1893

Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

I think 30 minutes is a great place to start, and we can adjust as needed.

Would you mind adding these timeouts to the other workflow jobs, like integration tests? I think 30 minutes should be fine for all of them actually.

@jackwcodes
Copy link
Contributor Author

@masenf thanks for looking at my PR, I have added a placeholder timeout for the remaining workflows as requested.

@jackwcodes
Copy link
Contributor Author

I believe this PR is ready to merge, the one failed test is due to #1887, it should pass otherwise.

Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@picklelo picklelo merged commit f1f02e4 into reflex-dev:main Oct 2, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add timeout to GitHub actions
3 participants