Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved Nodejs prerequisite check #2767

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

ansuzgs
Copy link
Contributor

@ansuzgs ansuzgs commented Mar 3, 2024

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

  • Bug fix (non-breaking change which fixes an issue)

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

Update the install_node() function to check if it was already installed.

b. Describe your changes.

I used the check_node_version() as a condition to check if node was already installed and the version was greater than the required one.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

closes #2752

Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well for me, thanks for adding!

@picklelo picklelo merged commit bbb9253 into reflex-dev:main Mar 4, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to reinstall node when it is installed
2 participants