[REF-2086] Avoid "Warning: The path to the Node binary could not be found. #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ound." When bootstrapping node itself, we do not need to warn the user that node cannot be found -- it's obviously not found because we're installing it right now. This warning leads some folks to believe that they need to install node themselves (for example in a docker container), when in reality, reflex will always try to install it's own known-good version of node first. Also avoid a nasty traceback when Reflex attempts to run node or npm, but it's not actually installed (instead, the warning will be displayed and it will say "Invalid Command"). Move the recently added check for node before installing node above the conditional so it can also skip node installation on Windows, which is especially slow.
So this just wastes time during CI
Next 14 has always required 18.17, so Reflex should have bumped this up a long time ago.
picklelo
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bootstrapping node itself, we do not need to warn the user that node cannot be found -- it's obviously not found because we're installing it right now. This warning leads some folks to believe that they need to install node themselves (for example in a docker container), when in reality, reflex will always try to install it's own known-good version of node first.
Also avoid a nasty traceback when Reflex attempts to run node or npm, but it's not actually installed (instead, the warning will be displayed and it will say "Invalid Command").
Move the recently added check (#2767) for node before installing node above the conditional so it can also skip node installation on Windows, which is especially slow.
Yes, I tested this on Windows.