Use old serializer system in LiteralVar #3875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masenf
previously approved these changes
Sep 4, 2024
| Raises: | ||
| VarTypeError: The operand types are unsupported. | ||
| """ | ||
| raise VarTypeError( |
There was a problem hiding this comment.
i think the proper thing to do in this scenario is to return NotImplemented [1]
Not sure if that totally makes sense for us though, because ostensibly we're not expecting an incompatible type to have a better comparison checker than the Var itself, and raising the exception means we fail loud and fast (and record the exception type for telemetry).
Not suggesting a change here, just posing a point for discussion.
There was a problem hiding this comment.
that seems valid, we would need to also remove .operation from Var for both to work. Then Python should do the heavy lifting for us.
When emitting a state update, restore `_self_mutable` to the value it had previously so that `yield` in the middle of `async with self` does not result in an immutable StateProxy. Fix #3869
If a component in the markdown component_map contains children components, use `_get_all_imports` to recursively enumerate them. Fix #3880
* Added API Endpoint * Added API Endpoint * Added Unit Tests * Added Unit Tests * main * Apply suggestions from Code Review * Fix Ruff Formatting * Update Socket Events * Async Functions
* Added API Endpoint * Added API Endpoint * Added Unit Tests * Added Unit Tests * main * Apply suggestions from Code Review * Fix Ruff Formatting * Update Socket Events * Async Functions
* Added API Endpoint * Added API Endpoint * Added Unit Tests * Added Unit Tests * main * Apply suggestions from Code Review * Fix Ruff Formatting * Update Socket Events * Async Functions
Co-authored-by: Masen Furer <m_github@0x26.net>
* simplify ImmutableComputedVar.__get__ * ruff it
masenf
approved these changes
Sep 10, 2024
benedikt-bartscher
added a commit
to benedikt-bartscher/reflex
that referenced
this pull request
Sep 10, 2024
This reverts commit a5c73ad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.