Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double down on bun over fnm/npm #4906

Merged
merged 13 commits into from
Mar 17, 2025
Merged

Conversation

adhami3310
Copy link
Member

makes initial setup faster (hopefully)

Copy link

codspeed-hq bot commented Mar 6, 2025

CodSpeed Performance Report

Merging #4906 will improve performances by 17.29%

Comparing double-down-on-bun-over-fnm/npm (b788c87) with main (d45e569)

Summary

⚡ 1 improvements
✅ 11 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_compile_stateful[_simple_page] 303.7 µs 258.9 µs +17.29%

@adhami3310
Copy link
Member Author

reflex-web is failing because of oven-sh/bun#17014

@masenf masenf mentioned this pull request Mar 7, 2025
32 tasks
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my system had an old version of node, that got picked up by bun run. we should use bun run --bun to make sure it uses bun runtime

@adhami3310
Copy link
Member Author

the issue with not using node is that reflex web would fail to compile :/

@Alek99
Copy link
Member

Alek99 commented Mar 16, 2025

the issue with not using node is that reflex web would fail to compile :/

Is this just because of spline?

@adhami3310
Copy link
Member Author

Is this just because of spline?

It is because of bun failing to compile an app with spline.

@adhami3310 adhami3310 merged commit 8c9bc66 into main Mar 17, 2025
43 checks passed
@adhami3310 adhami3310 deleted the double-down-on-bun-over-fnm/npm branch March 17, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants