Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add retirement label on credit class #48

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

flagrede
Copy link
Collaborator

@flagrede flagrede commented Oct 3, 2023

Description

Part of: regen-network/regen-web#2052

  • add retirement label and icon to credit class

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • added new items content to ./deskStructure.js
  • go through "Deploying to production" instructions after this PR (and other PRs depending on this one, e.g. on regen-network/regen-web, if applicable) get merged

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • reviewed documentation is accurate
  • manually tested (if applicable)

@flagrede flagrede requested a review from a team October 3, 2023 08:14
Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving, pending small nits

schemas/documents/registry/creditClass.js Outdated Show resolved Hide resolved
schemas/documents/registry/creditClass.js Outdated Show resolved Hide resolved
@flagrede flagrede merged commit 9e4e1a5 into main Oct 9, 2023
@flagrede flagrede deleted the fix-2052-certificate-retirement-label branch October 9, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants