Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dynamic certificate label and icon #2166

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

flagrede
Copy link
Collaborator

@flagrede flagrede commented Oct 3, 2023

Description

Closes: #2052
Needs: regen-network/regen-sanity#48

  • Use credit class label and icon from sanity, if they exist, to display certificate

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. with sanity credit class: https://deploy-preview-2166--regen-marketplace.netlify.app/certificate/WyJyZXRpcmVtZW50cyIsMSwxMDAyMTcwNSwwLDBd
  2. without sanity credit class: https://deploy-preview-2166--regen-marketplace.netlify.app/certificate/WyJyZXRpcmVtZW50cyIsMSw5ODAyNDM3LDAsMF0=

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit df0f842
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/6523abe086a62000089fc16e
😎 Deploy Preview https://deploy-preview-2166--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flagrede flagrede requested a review from a team October 3, 2023 12:39
@flagrede
Copy link
Collaborator Author

flagrede commented Oct 3, 2023

@erikalogie you can test that the certificate is now dynamic here (I've updated the C01 credit class in sanity):

@erikalogie
Copy link
Collaborator

@flagrede LGTM!

Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small nit

@flagrede flagrede force-pushed the fix-2052-certificate-retirement-label branch from 5497a8e to df0f842 Compare October 9, 2023 07:29
@flagrede flagrede merged commit eeb6a0b into dev Oct 9, 2023
@flagrede flagrede deleted the fix-2052-certificate-retirement-label branch October 9, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All retirement certificates use "carbon offset" regardless of credit type
3 participants