-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add build number editing for v1 recipes #3009
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3009 +/- ##
==========================================
+ Coverage 76.23% 76.26% +0.03%
==========================================
Files 115 118 +3
Lines 12559 12628 +69
==========================================
+ Hits 9574 9631 +57
- Misses 2985 2997 +12 ☔ View full report in Codecov by Sentry. |
Note: I added a fix to be able to pass a callable for IMO this could still be reviewed/merged separately and I could take care of managing the two PRs, as you prefer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments. Also the module names of v1
and yaml
are easy to stomp on. Let's
- rename the
v1
module to something longer likev1_recipes
or w/e. - rename the yaml module to something else and possibly combine those routines into the ones in the utils module or the recipe parser module
I made the changes:
Let me know if there is anything else |
@beckermr - the 'safe' loader doesn't seem to be able to preserve the quotes - which one do we care about more? |
Switched (back) to |
|
No description provided.