Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test v1 recipe.yaml migrations #3011

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

wolfv
Copy link
Contributor

@wolfv wolfv commented Sep 24, 2024

I added some tests modeled after the other migration tests.

The matplotlib test currently raises an NotImplemented Error:

            elif isinstance(recipe_yaml, str):
                raise NotImplementedError(
                    "recipe_yaml generic parsing not implemented yet! Ensure the feedstock has .ci_support files."
                )

@beckermr - do we need to do that first? I am not entirely sure what this code does.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 55.11364% with 79 lines in your changes missing coverage. Please review.

Project coverage is 76.09%. Comparing base (228761a) to head (6b670c7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_migrators_v1.py 54.33% 79 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3011      +/-   ##
==========================================
- Coverage   76.26%   76.09%   -0.18%     
==========================================
  Files         118      119       +1     
  Lines       12628    12803     +175     
==========================================
+ Hits         9631     9742     +111     
- Misses       2997     3061      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beckermr
Copy link
Contributor

@wolfv can you rebase this?

Then I can review.

@wolfv
Copy link
Contributor Author

wolfv commented Sep 24, 2024

Yes, will do tomorrow! (In a few hours)

@wolfv
Copy link
Contributor Author

wolfv commented Sep 25, 2024

@beckermr rebased! :)

@beckermr beckermr merged commit b744e01 into regro:main Sep 25, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants