-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moon support #11
Comments
Previously discussed in AitorDB#144 by @Danieldiazi @modul8 @Tom-ahawk @Tontze I would love to support this. The mechanics etc are very similar. Maybe another color styling would be appropriate. The biggest issue is that home assistant does not have a native All and @selfish: Wdyt, would the name "lovelace-sun-card" still be fitting in this case? We could rename the project at this point of its young life. Feels like a nice touch that the successor to the "Sun Card" would be called "Sun Moon Card" |
That's an interesting idea; let's investigate it. I can look into it next week. After a quick glance at the |
Using the AstroWeather integration you will get these sensors: Or this API:
|
You can use this:Broham/suncalcPy: A python implementation of the SunCalc javascript library.github.com Ormourner/suncalc: A tiny JavaScript library for calculating sun/moon positions and phases.github.comOn 18 Mar 2023, at 20:39, Tom-ahawk ***@***.***> wrote:
Using the AstroWeather integration you will get these sensors:
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I would love to see the moon in the same card with a different color. looking forward to see your developments on this. |
@ThomDietrich @avataar We have several options for adding optional support for the moon. I'd love to see this happen. I think we can go ahead and rename. |
It's a good idea but let's not jump ahead with renaming things just yet. I'd first like to see the project stable and released before we decide on the bright future :) |
All, please hold your horses :) The only thing we need to discuss and decide ASAP is, whether we want to rename the project BEFORE publishing to HACS. Options:
Update: Let's timebox this decision till Tuesday evening 🚀 |
I was thinking of other stuff that also could refer to more than just the sun:
|
Since this is what the card currently does, it's the most fitting and it's a drop in replacement for the original project, i.e. having "custom:sun-card" in your existing dashboard will continue to work.
Since we still don't have moon support, the name doesn't fit. I don't believe other celestial objects are needed either.
"Sky Card" is a good fit if we really want to reserve the opportunity to add something other than the Sun in the future. "Horizon Card" (based on @tjorim's suggestions) sounds good too. Regarding the name of the repository, I think "lovelace-xxx-card" is better than "dashboard-xxx-card" as "lovelace" is a very specific term that refers to HA unambiguously while "dashboard" is very generic, but I have no strong opinion on that one. |
I love the horizon-card option, leaves all options open for further developments. |
The name Let's have the community decide:
|
This card is not related to "Astrology", which is mainly considered a pseudoscience nowadays. |
"Sky card" would have my vote. 😜 |
@edwardtfn you caught me off guard there. I feel ashamed that I've mixed terms known from clown culture and science 🙈 The majority has spoken :) We have a winner. |
Nooo -- I tuned in too late! Would have voted for |
@lcnittl care to elaborate? :-) https://dictionary.cambridge.org/de/worterbuch/englisch/luminary |
@ThomDietrich absolutely! It is a (slightly older, probably) term for (shining) celestial/heavenly bodies. From https://en.wikipedia.org/wiki/Luminary
From https://en.wiktionary.org/wiki/luminary#Noun
But also some more famous dictionaries mention it, like Merriam-Webster and Collins. So a nice collective term for both sun and moon (and others). |
Here is a preview of the upcoming Moon support (different locations and times): What is the new Moon stuff:
This is how it looks with different fields shown/hidden: There are other non-moon related changes, see #40 for details. |
Request for help with translations: I've created a Google sheet to gather translations for "moonrise" and "moonset": https://docs.google.com/spreadsheets/d/19CETx--HXXTW0NzyivpMcmqT7VBGOR_HTt27i5XsR7U/edit?usp=sharing. Add a translation in as many languages as you feel confident in. |
It's a bit questionable call the Moon as an object that "gives light", no? 😜 |
- Completely revamped calculations and Sun graph, now way more realistic - Moon support: Moon on the graph, moonrise, moonset, Moon phase, Moon elevation and Moon azimuth - Obeys Home Assistant's settings for time and number formatting - Cleaned up config options - Font size adjustments, including the smaller AM/PM text from the original card - Lots of tests - All lint warnings gone Resolves the following issues: - #11 - Moon support - #30 - Horizon-card customize with card-mod - #40 - More realistic visualization and own source of Sun data - #54 - 24h format not working by default
- Completely revamped calculations and Sun graph, now way more realistic - Moon support: Moon on the graph, moonrise, moonset, Moon phase, Moon elevation and Moon azimuth - Obeys Home Assistant's settings for time and number formatting - Cleaned up config options - Font size adjustments, including the smaller AM/PM text from the original card - Lots of tests - All lint warnings gone Resolves the following issues: - #11 - Moon support - #30 - Horizon-card customize with card-mod - #40 - More realistic visualization and own source of Sun data - #54 - 24h format not working by default - #58 - Support HA 2023.7's local/server time zone setting
- Completely revamped calculations and Sun graph, now way more realistic - Moon support: Moon on the graph, moonrise, moonset, Moon phase, Moon elevation and Moon azimuth - Obeys Home Assistant's settings for time and number formatting - Cleaned up config options - Font size adjustments, including the smaller AM/PM text from the original card - Lots of tests - All lint warnings gone Resolves the following issues: - #11 - Moon support - #30 - Horizon-card customize with card-mod - #40 - More realistic visualization and own source of Sun data - #54 - 24h format not working by default - #58 - Support HA 2023.7's local/server time zone setting
How about adding support for the moon?
The text was updated successfully, but these errors were encountered: