Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create lovelace-sun-card.js #13

Closed
wants to merge 5 commits into from
Closed

Conversation

edwardtfn
Copy link
Collaborator

To align with hacs requirements and stop failing validations

@ThomDietrich
Copy link

Is it required to commit the build, rather than uploading as a Release asset?

Thanks for the PR, I want to wait for the decision in #11

@edwardtfn
Copy link
Collaborator Author

edwardtfn commented Mar 18, 2023

For having the HACS custom repository badge we just need the directory structure on the right format, which basically means having the file /dist/lovelace-sun-card.js in the repo (among other things that I believe are all set).
In order to publish at HACS default directory (HACS store?) you need also to pass the HACS Actions validation with the latest merge. You will be requested to share the link for that validation instance.
The other changes here are for renaming the file to lovelace-sun-card.js, which I have to do in order to be able to compile lovelace-sun-card.js.
A saw later that those rename are also done in PR #4. As far as I could see we have a couple of different changes related to this, so probably will be super easy to merge this PR here after that other PR #4 is merged.
Anyways, I think we should run a bit in other to have it included into HACS default on their next merge (I don't know when). There are a bunch of other PRs in their queue already.
I've done all this process with a copy of the original repo, to the point to create a PR into HACS default, so I'm quite confident we can fix any bug (if any) that comes with those new functionalities quite quickly.
I liked the idea of renaming to the recommended format. I think we will get better future-proof solution if we go this way.
Count on me!!

@selfish
Copy link

selfish commented Mar 18, 2023

@edwardtfn and @ThomDietrich, let's wait for #4 before merging this. We don't need to keep the JavaScript file in the repository; it's only necessary for the release. GitHub Actions can add it to the release automatically, so that's the best option. This eliminates the need for manual updates and commits. #4 implements this, and I'll make it operational shortly.

@edwardtfn
Copy link
Collaborator Author

I'm totally fine with waiting... 😉

@avataar
Copy link
Collaborator

avataar commented Mar 22, 2023

Obsolete - resolved through other PRs.

@avataar avataar closed this Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants