-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create lovelace-sun-card.js #13
Conversation
To align with hacs requirements and stop failing validations
Is it required to commit the build, rather than uploading as a Release asset? Thanks for the PR, I want to wait for the decision in #11 |
For having the HACS custom repository badge we just need the directory structure on the right format, which basically means having the file /dist/lovelace-sun-card.js in the repo (among other things that I believe are all set). |
@edwardtfn and @ThomDietrich, let's wait for #4 before merging this. We don't need to keep the JavaScript file in the repository; it's only necessary for the release. GitHub Actions can add it to the release automatically, so that's the best option. This eliminates the need for manual updates and commits. #4 implements this, and I'll make it operational shortly. |
I'm totally fine with waiting... 😉 |
Obsolete - resolved through other PRs. |
To align with hacs requirements and stop failing validations