Add support for multiple streams (channels) per Node #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They can have simpler names since they are no longer part of the generated code .
johningve
added a commit
to relab/hotstuff
that referenced
this pull request
Mar 25, 2021
This makes use of the work-in-progress channels in Gorums (see relab/gorums#131). We can use a dedicated channel for all messages that are core to the protocol, such that they are all handled synchronously, and then another channel for other messages, such as fetch requests/responses. This allows us to do RPC messages on the event loop goroutine. We can thus make the fetch operation part of the BlockChain.Get() method, which simplifies things a lot. However, logs show that allowing each call to Get() to attempt to fetch blocks from other replicas will generate a lot of unnecessary fetch attempts. To combat this, we add a LocalGet() method which should be used instead of Get() when it is undesirable to fetch a missing block. Special attention is needed in OnVote(), because it can very often fail to find its blocks. Thus, we add the AwaitEvent() method to the event loop. This method allows us to reschedule a vote event to run after the next proposal event occurs. This allows us to avoid around 90% of OnVote-initiated fetch attempts, according to my measurements. OnVote will attempt to reschedule the event the first time it fails to find its block. The second time, it will try to fetch the block.
This adds a Close() function to channels, and makes Node.NewChannel() call Channel.Connect()
This allows us to differentiate between a canceled call and a call that received errors.
|
Closing in favor of #140. Might revisit the multiple channels idea in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to make it possible to have multiple
Channels(formerlyorderedNodeStream) perNode. Currently, the channel for a call can be changed from the default by passing either a*gorums.Channelor a[]*gorums.Channelas aConfigOption.