Refactor and rename orderedNodeStream and receiveQueue #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They can have simpler names since they are no longer part of the generated code .
This also includes some changes that will make supporting multiple channels easier in the future.
Instead, channels will provide an enqueue function where calltypes can pass a channel to receive responses on.
The race detector complained about the streamBroken boolean, so this commit makes it atomic.
meling
reviewed
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up and renames some of the types that implement our "node streams". Before, when we included most of the gorums code in the generated code, it was important that the names of our methods and types did not conflict with other generated code from protobuf and grpc. Now, most of that code has been moved into the gorums package, which is imported by the generated code.
Some of the name changes:
orderedNodeStream=>channelgorumsStreamRequest=>requestgorumsStreamResult=>responseAlso, I have removed the
receiveQueuestruct. The manager now provides agetMsgID()function instead, and the "routing" of response messages is handled by the channels. This seems to have improved performance for async quorum calls, but I'm not sure why. Possibly due to reducing lock contention?