Decode HTML entities by default on node #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set parser options `decodeEntities` to true for `html-dom-parser`, which gets passed to `htmlparser2`. Write test to confirm that entities passed to React element's children are decoded (but they will still be encoded when rendered by ReactDOMServer).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
HTML entities aren't decoded by default for
htmlparser2(initialized byhtml-dom-parser). As a result, this will lead to anInvariant Violationbecause the entities are decoded on the client-side.The fix is to always set
decodeEntities: trueforhtmlparser2.Resolves #34.
Tasks:
decodeEntitiesto true forhtml-dom-parser, which gets passed tohtmlparser2